card: add top image attributes for lazy loading#1283
Merged
Conversation
This will be useful for long image gallery. Developped according to [HTML specs of img tag](https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/img#lazy)
lovasoa
requested changes
May 12, 2026
Comment on lines
+1
to
+7
| INSERT INTO parameter(component, name, description, type, top_level, optional) SELECT 'card', * FROM (VALUES | ||
| -- item level | ||
| ('top_image_lasy', 'Whether the top image must be lazily or eagerly loaded. Defaults to false, meaning eagerly', 'BOOLEAN', FALSE, TRUE), | ||
| ('top_image_width', 'Specify the top image width, in pixel. Help preventing a layout shift', 'INTEGER', FALSE, TRUE), | ||
| ('top_image_height', 'Specify the top image height, in pixel. Help preventing a layout shift', 'INTEGER', FALSE, TRUE) | ||
| ) x; | ||
|
|
Collaborator
There was a problem hiding this comment.
can we directly edit the existing migration ? The official site recreates the db from scratch on every deploy anyway
Contributor
Author
There was a problem hiding this comment.
Sure
I see your commit in this way.
Do I have to do anything else?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be useful for long image gallery.
Developped according to HTML specs of img tag