Skip to content

Add reboot API facade helper#46

Merged
spyroot merged 1 commit into
mainfrom
neroshige/d1-api-facade-reboot
Jul 10, 2026
Merged

Add reboot API facade helper#46
spyroot merged 1 commit into
mainfrom
neroshige/d1-api-facade-reboot

Conversation

@spyroot

@spyroot spyroot commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • add a typed RebootResult plus a reboot() facade wrapper over the existing reboot command
  • make facade resets preview by default, with confirm=True required for execution
  • cover the wrapper with unit tests and GB300 corpus-backed dry-run coverage through the command registry

Tests

  • conda run -n idrac_ctl pytest -q tests/test_api_facade.py
  • conda run -n idrac_ctl ruff check redfish_ctl/api.py tests/test_api_facade.py
  • conda run -n idrac_ctl pytest -q

@spyroot

spyroot commented Jul 10, 2026

Copy link
Copy Markdown
Owner Author

Reviewed and approved on the merits — reboot previews by default (confirm=False -> dry_run=True), waits only when confirmed, RebootResult is frozen, and tests assert GET-only in the default path. Can't merge as-is: the GPU/NTP facade helpers landed on main first, so this now conflicts on redfish_ctl/api.py and tests/test_api_facade.py. Please rebase onto main and re-apply the reboot helper and its tests after the new helpers. Clean merge after that.

@spyroot spyroot force-pushed the neroshige/d1-api-facade-reboot branch from 08b723c to 983cef4 Compare July 10, 2026 19:36
@spyroot spyroot merged commit b614e1d into main Jul 10, 2026
3 checks passed
@spyroot spyroot deleted the neroshige/d1-api-facade-reboot branch July 10, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant