Skip to content

module install via npm e.g. npm:name[@version]#122

Open
knownasilya wants to merge 4 commits into
spolu:masterfrom
knownasilya:module-npm
Open

module install via npm e.g. npm:name[@version]#122
knownasilya wants to merge 4 commits into
spolu:masterfrom
knownasilya:module-npm

Conversation

@knownasilya

Copy link
Copy Markdown

This is a WIP. Would love any help 😄. In response to #121.

@matthewjamesr

Copy link
Copy Markdown

What if I create a full web service for uploading modules etc, and we can modify breach core to use mpm://module_name pointing to the website?

Or at a minimum, be a central page to link to everyone's module repo?

@knownasilya

Copy link
Copy Markdown
Author

@matthewjamesr working on it here: mod_findmod. Would love any help, here are some questions that I would love help with.

@spolu

spolu commented Jul 14, 2014

Copy link
Copy Markdown
Owner

So we agree we can close this PR. module discovery will belong to its own module right? cc @knownasilya

@spolu spolu closed this Jul 14, 2014
@knownasilya

Copy link
Copy Markdown
Author

@spolu sounds like a plan.

@spolu

spolu commented Jul 14, 2014

Copy link
Copy Markdown
Owner

Sorry reopening, as this is totally belonging to the module manger

@spolu spolu reopened this Jul 14, 2014
@knownasilya

Copy link
Copy Markdown
Author

😄 felt like I was missing something haha

@spolu

spolu commented Jul 16, 2014

Copy link
Copy Markdown
Owner

So this is awesome. Only you allow (and you should) an empty version for the npm package but you don't proceed to discover the latest version in augment_path.

Which would lead to some issues with auto-updates if there is no proper version associated with the path.

Can you update the PR so that the npm version is discovered there?

@spolu

spolu commented Jul 16, 2014

Copy link
Copy Markdown
Owner

Otherwise I'll take over from here. Just let me know!

Ilya Radchenko added 3 commits July 17, 2014 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants