Skip to content

Add jpeg blob capture#49

Open
nijk wants to merge 2 commits into
spite:masterfrom
nijk:add-jpeg-blob-capture
Open

Add jpeg blob capture#49
nijk wants to merge 2 commits into
spite:masterfrom
nijk:add-jpeg-blob-capture

Conversation

@nijk

@nijk nijk commented Apr 21, 2017

Copy link
Copy Markdown
Contributor

Addresses issue #48

@spite

spite commented Apr 21, 2017

Copy link
Copy Markdown
Owner

So what does this return when .save() is called?

@nijk

nijk commented Apr 21, 2017

Copy link
Copy Markdown
Contributor Author

I guess I haven't really catered for the case where .save() is called without a callback - I suppose I haven't considered it because it doesn't really make sense to do that when you want to obtain an array of blobs rather than having the capturer download a collection of files for you.

On reflection, it may be a better pattern to augment the existing CCJPEGEncoder to allow the flexibility of a Tar of Images or Array of Blobs on .save() and also allow for the callback on each frame .add().

@nijk

nijk commented Apr 24, 2017

Copy link
Copy Markdown
Contributor Author

@spite Any thoughts on this?

@spite

spite commented May 8, 2017

Copy link
Copy Markdown
Owner

I guess I don't understand why you need to create a new Frame Encoder. Why doesn't the current JPEG/PNG encoder work for your needs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants