Count TCP sockets from creation - #3707
Merged
fibonacci1729 merged 1 commit intoSep 2, 2026
Merged
Conversation
carsonfarmer
marked this pull request as draft
September 2, 2026 00:00
Contributor
Author
|
Much better/simpler. |
Acquire socket quota before Wasmtime creates the host socket. Track the permit with the socket resource so unconnected sockets cannot bypass the configured limit. Signed-off-by: carsonfarmer <carson.farmer@gmail.com> Co-authored-by: Codex <noreply@openai.com>
carsonfarmer
force-pushed
the
cf/fix-tcp-socket-quota
branch
from
September 2, 2026 01:30
bf7a63b to
271e5fb
Compare
carsonfarmer
marked this pull request as ready for review
September 2, 2026 03:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3706.
TCP socket creation already opens an operating-system socket, but Spin did not acquire quota until connect. Unconnected sockets could therefore bypass
max_socket_connectionsandmax_total_connections.This change acquires quota when P2 or P3 creates the socket. The existing resource tracking releases it when the socket is dropped.
Tests cover both APIs, socket and instance cleanup, and shared limits.
Tests
cargo test -p spin-factor-wasicargo test -p spin-factor-outbound-networkingmake test-unitmake lintmake build