Skip to content

Support a new x-sourcemeta-one:priority collection hint#951

Merged
jviotti merged 3 commits into
mainfrom
priority-key-list
May 26, 2026
Merged

Support a new x-sourcemeta-one:priority collection hint#951
jviotti merged 3 commits into
mainfrom
priority-key-list

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented May 26, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Re-trigger cubic

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 26, 2026

🤖 Augment PR Summary

Summary: This PR introduces a new per-collection hint, x-sourcemeta-one:priority, to help consumers rank or filter schema collections.

Changes:

  • Documented the new hint in docs/configuration.md with a 0–100 range.
  • Extended the collection JSON Schema to allow x-sourcemeta-one:priority as an integer (0–100).
  • Added Configuration::priority() to read/clamp the hint (defaulting to 100 when absent).
  • Updated configuration dereferencing to propagate self_path and auto-assign priority 0 to built-in “self” collections.
  • Adjusted CLI and unit tests to expect the new metadata in generated configuration output.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread docs/configuration.md
Comment thread test/unit/configuration/configuration_test.cc
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 728f40c Previous: fa9a8af Ratio
Add one schema (0 existing) 300 ms 246 ms 1.22
Add one schema (100 existing) 26 ms 19 ms 1.37
Add one schema (1000 existing) 83 ms 63 ms 1.32
Add one schema (10000 existing) 808 ms 659 ms 1.23
Update one schema (1 existing) 21 ms 14 ms 1.50
Update one schema (101 existing) 26 ms 20 ms 1.30
Update one schema (1001 existing) 82 ms 62 ms 1.32
Update one schema (10001 existing) 655 ms 541 ms 1.21
Cached rebuild (1 existing) 5 ms 3 ms 1.67
Cached rebuild (101 existing) 7 ms 5 ms 1.40
Cached rebuild (1001 existing) 28 ms 17 ms 1.65
Cached rebuild (10001 existing) 245 ms 158 ms 1.55
Index 100 schemas 155 ms 87 ms 1.78
Index 1000 schemas 1191 ms 685 ms 1.74
Index 10000 schemas 14354 ms 10714 ms 1.34

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 728f40c Previous: fa9a8af Ratio
Add one schema (0 existing) 296 ms 294 ms 1.01
Add one schema (100 existing) 28 ms 29 ms 0.97
Add one schema (1000 existing) 82 ms 81 ms 1.01
Add one schema (10000 existing) 656 ms 651 ms 1.01
Update one schema (1 existing) 21 ms 21 ms 1
Update one schema (101 existing) 29 ms 28 ms 1.04
Update one schema (1001 existing) 82 ms 82 ms 1
Update one schema (10001 existing) 662 ms 660 ms 1.00
Cached rebuild (1 existing) 7 ms 6 ms 1.17
Cached rebuild (101 existing) 9 ms 9 ms 1
Cached rebuild (1001 existing) 28 ms 28 ms 1
Cached rebuild (10001 existing) 242 ms 247 ms 0.98
Index 100 schemas 122 ms 121 ms 1.01
Index 1000 schemas 1068 ms 1232 ms 0.87
Index 10000 schemas 13409 ms 13951 ms 0.96

This comment was automatically generated by workflow using github-action-benchmark.

jviotti added 2 commits May 26, 2026 10:24
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit d6d5aa6 into main May 26, 2026
5 checks passed
@jviotti jviotti deleted the priority-key-list branch May 26, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant