Skip to content

Use -g1 when computing debug symbols#949

Merged
jviotti merged 1 commit into
mainfrom
g1-symbols
May 25, 2026
Merged

Use -g1 when computing debug symbols#949
jviotti merged 1 commit into
mainfrom
g1-symbols

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented May 25, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti changed the title Use -g1 when computing debug systems Use -g1 when computing debug symbols May 25, 2026
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 25, 2026

🤖 Augment PR Summary

Summary: Switch global debug-symbol compilation from -g to -g1 when ONE_DEBUG_SYMBOLS is enabled.
Rationale: Keeps line-table info for crash symbolication while reducing LTO link time and extracted debug sidecar size.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread cmake/DebugSymbols.cmake
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 6242af7 Previous: 90f0040 Ratio
Add one schema (0 existing) 293 ms 285 ms 1.03
Add one schema (100 existing) 27 ms 26 ms 1.04
Add one schema (1000 existing) 85 ms 84 ms 1.01
Add one schema (10000 existing) 924 ms 819 ms 1.13
Update one schema (1 existing) 19 ms 18 ms 1.06
Update one schema (101 existing) 26 ms 27 ms 0.96
Update one schema (1001 existing) 84 ms 85 ms 0.99
Update one schema (10001 existing) 718 ms 709 ms 1.01
Cached rebuild (1 existing) 6 ms 6 ms 1
Cached rebuild (101 existing) 9 ms 8 ms 1.13
Cached rebuild (1001 existing) 30 ms 30 ms 1
Cached rebuild (10001 existing) 277 ms 311 ms 0.89
Index 100 schemas 161 ms 111 ms 1.45
Index 1000 schemas 1191 ms 875 ms 1.36
Index 10000 schemas 13718 ms 13189 ms 1.04

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 6242af7 Previous: 90f0040 Ratio
Add one schema (0 existing) 180 ms 289 ms 0.62
Add one schema (100 existing) 20 ms 28 ms 0.71
Add one schema (1000 existing) 76 ms 81 ms 0.94
Add one schema (10000 existing) 694 ms 676 ms 1.03
Update one schema (1 existing) 15 ms 21 ms 0.71
Update one schema (101 existing) 19 ms 28 ms 0.68
Update one schema (1001 existing) 65 ms 83 ms 0.78
Update one schema (10001 existing) 694 ms 696 ms 1.00
Cached rebuild (1 existing) 5 ms 6 ms 0.83
Cached rebuild (101 existing) 6 ms 9 ms 0.67
Cached rebuild (1001 existing) 22 ms 29 ms 0.76
Cached rebuild (10001 existing) 202 ms 254 ms 0.80
Index 100 schemas 76 ms 119 ms 0.64
Index 1000 schemas 652 ms 1152 ms 0.57
Index 10000 schemas 12846 ms 14015 ms 0.92

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit fa9a8af into main May 25, 2026
5 checks passed
@jviotti jviotti deleted the g1-symbols branch May 25, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant