Upgrade Core and Blaze#762
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR upgrades the vendored Sourcemeta dependencies (Core, Blaze, JSONBinPack) and updates jsonschema to match Blaze’s new component split. Changes:
Technical Notes: The CLI now explicitly links the new Blaze component targets to reflect the upstream library split and avoid missing symbols when building statically. 🤖 Was this summary useful? React with 👍 or 👎 |
| target_link_libraries(sourcemeta_blaze_compiler PUBLIC | ||
| sourcemeta::blaze::frame) | ||
| target_link_libraries(sourcemeta_blaze_compiler PRIVATE | ||
| sourcemeta::blaze::bundle) |
There was a problem hiding this comment.
Because sourcemeta_library() respects BUILD_SHARED_LIBS (and this repo’s build defaults it to OFF), keeping sourcemeta::blaze::bundle as a PRIVATE dependency here can force consumers of the static sourcemeta::blaze::compiler target to manually add bundle to avoid unresolved symbols. Same concern applies to other Blaze targets that link frame/bundle as PRIVATE while using their symbols.
Severity: medium
Other Locations
vendor/blaze/src/codegen/CMakeLists.txt:21vendor/blaze/src/format/CMakeLists.txt:15vendor/blaze/src/documentation/CMakeLists.txt:13vendor/blaze/src/editor/CMakeLists.txt:13vendor/blaze/src/configuration/CMakeLists.txt:14
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com