Skip to content

Upgrade Core and Blaze#762

Merged
jviotti merged 1 commit into
mainfrom
more-upgrades
May 22, 2026
Merged

Upgrade Core and Blaze#762
jviotti merged 1 commit into
mainfrom
more-upgrades

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented May 22, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 64 files

Re-trigger cubic

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 22, 2026

🤖 Augment PR Summary

Summary: This PR upgrades the vendored Sourcemeta dependencies (Core, Blaze, JSONBinPack) and updates jsonschema to match Blaze’s new component split.

Changes:

  • Bumped Core/Blaze/JSONBinPack revisions in DEPENDENCIES and vendor dependency pins.
  • Linked the CLI against new Blaze libraries (frame, bundle, format) and added the corresponding includes in command sources.
  • Refactored vendored Blaze: introduced new frame, bundle, and format subprojects and updated Blaze’s CMake/component config to expose them.
  • Moved frame/bundle/format implementations out of Blaze “foundation” into their own libraries; updated alterschema/codegen/compiler/editor/output accordingly.
  • Updated JSONBinPack’s CMake package dependency to request Blaze’s bundle component.
  • Adjusted Core’s default compiler flags (gate vectorization/unrolling outside Debug; keep overflow semantics flags consistent).
  • Disabled LTO for GoogleTest executables to speed up links in Release builds.

Technical Notes: The CLI now explicitly links the new Blaze component targets to reflect the upstream library split and avoid missing symbols when building statically.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

target_link_libraries(sourcemeta_blaze_compiler PUBLIC
sourcemeta::blaze::frame)
target_link_libraries(sourcemeta_blaze_compiler PRIVATE
sourcemeta::blaze::bundle)
Copy link
Copy Markdown

@augmentcode augmentcode Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because sourcemeta_library() respects BUILD_SHARED_LIBS (and this repo’s build defaults it to OFF), keeping sourcemeta::blaze::bundle as a PRIVATE dependency here can force consumers of the static sourcemeta::blaze::compiler target to manually add bundle to avoid unresolved symbols. Same concern applies to other Blaze targets that link frame/bundle as PRIVATE while using their symbols.

Severity: medium

Other Locations
  • vendor/blaze/src/codegen/CMakeLists.txt:21
  • vendor/blaze/src/format/CMakeLists.txt:15
  • vendor/blaze/src/documentation/CMakeLists.txt:13
  • vendor/blaze/src/editor/CMakeLists.txt:13
  • vendor/blaze/src/configuration/CMakeLists.txt:14

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@jviotti jviotti merged commit c3c7de2 into main May 22, 2026
15 checks passed
@jviotti jviotti deleted the more-upgrades branch May 22, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant