Do not restrict parallelism on Makefile

[jviotti]

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

[augmentcode]

🤖 Augment PR Summary

Summary: This PR removes the hard-coded build parallelism limit from the project Makefile.

Changes:

• Drops --parallel 4 from the main cmake --build invocation so concurrency is no longer capped by the Makefile

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

Removing --parallel here may cause cmake --build to run effectively single-threaded for some generators (e.g., Unix Makefiles), which seems opposite to the PR intent of “not restricting parallelism”. Is the intent to rely on CMAKE_BUILD_PARALLEL_LEVEL/generator defaults instead?

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="Makefile">

<violation number="1" location="Makefile:25">
P2: Removing `--parallel 4` entirely (rather than replacing with `--parallel` with no argument) may cause single-threaded builds when using the Unix Makefiles generator, since `make` does not parallelize by default. Using `--parallel` without a number would let the native build tool choose its default parallelism (e.g., Ninja uses cores+2, and `CMAKE_BUILD_PARALLEL_LEVEL` can override). This better matches the intent of not artificially restricting parallelism.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P2: Removing --parallel 4 entirely (rather than replacing with --parallel with no argument) may cause single-threaded builds when using the Unix Makefiles generator, since make does not parallelize by default. Using --parallel without a number would let the native build tool choose its default parallelism (e.g., Ninja uses cores+2, and CMAKE_BUILD_PARALLEL_LEVEL can override). This better matches the intent of not artificially restricting parallelism.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At Makefile, line 25:

<comment>Removing `--parallel 4` entirely (rather than replacing with `--parallel` with no argument) may cause single-threaded builds when using the Unix Makefiles generator, since `make` does not parallelize by default. Using `--parallel` without a number would let the native build tool choose its default parallelism (e.g., Ninja uses cores+2, and `CMAKE_BUILD_PARALLEL_LEVEL` can override). This better matches the intent of not artificially restricting parallelism.</comment>

<file context>
@@ -22,7 +22,7 @@ configure: .always
 compile: .always
 	$(CMAKE) --build ./build --config $(PRESET) --target clang_format
-	$(CMAKE) --build ./build --config $(PRESET) --parallel 4
+	$(CMAKE) --build ./build --config $(PRESET)
 	$(CMAKE) --install ./build --prefix ./build/dist --config $(PRESET) --verbose \
 		--component sourcemeta_core
</file context>

Suggested change

	$(CMAKE) --build ./build --config $(PRESET)
	$(CMAKE) --build ./build --config $(PRESET) --parallel