[FUNCTION_RESOLVER] Fix issue that instantiated unused wrapper type#55
Open
TheRedDaemon wants to merge 1 commit intomainfrom
Open
[FUNCTION_RESOLVER] Fix issue that instantiated unused wrapper type#55TheRedDaemon wants to merge 1 commit intomainfrom
TheRedDaemon wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #28 , but I would not necessarily close it yet, since there would also be the question where those print definitions should be stored. I would be for some sub-folder of core.
Anyway, due to the typedefs directly nested inside the Resolver, the wrapper of the function was always initiated, even if no wrapper was requested. This would require printers for all types and would likely add to the compile time.
Through the changes, the wrapper is only instantiated if it is really needed. And only then, the need to handle unknown types to print arises.