Skip to content

refactor(chore): remove Node js 20 support#288

Merged
yeshamavani merged 1 commit into
masterfrom
GH-287
Jun 16, 2026
Merged

refactor(chore): remove Node js 20 support#288
yeshamavani merged 1 commit into
masterfrom
GH-287

Conversation

@Sourav-kashyap

Copy link
Copy Markdown
Contributor

remove Node js 20 support

BREAKING CHANGE:
yes

GH-287

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine

Build:

Screenshot 2026-06-11 at 3 45 35 PM

Test:

Screenshot 2026-06-11 at 3 45 50 PM

@Sourav-kashyap Sourav-kashyap self-assigned this Jun 11, 2026
@Sourav-kashyap Sourav-kashyap linked an issue Jun 11, 2026 that may be closed by this pull request

@rohit-sourcefuse rohit-sourcefuse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 20 removal and the workflow/matrix changes look clean. One thing to fix before merge: package.json sets engines.node to "22 || 24", but the regenerated package-lock.json root still has ">=22" — the lockfile was generated before the engines value was changed and not re-run. Re-run npm install so they match.

Suggestion: standardize on ">=22" for a published library — "22 || 24" excludes Node 23 and every future LTS (26, 28…), so the package would refuse to install on the next LTS until another bump. Don't over-constrain consumers. Checks are green otherwise.

remove Node js 20 support

BREAKING CHANGE:
yes

GH-287
@sonarqubecloud

Copy link
Copy Markdown

SonarQube reviewer guide

Summary: Drops Node.js 20 support and updates to v10.1.0, removing the undici dependency while bumping numerous development and production dependency versions to their latest releases.

Review Focus: The primary concerns are:

  • Engine requirement change from >=20 to 22 || 24 is a significant constraint that may impact users still on Node.js 20
  • Undici removal from dependencies - verify this doesn't break any functionality that relied on it
  • Wide-ranging dependency updates across the ecosystem - ensure no breaking changes are introduced

Start review at: .github/workflows/main.yaml. This file shows the Node.js version matrix was reduced from [20, 22, 24] to [22, 24], which is the architectural change that drives the entire PR. Understanding this decision is critical before evaluating the package.json changes, as it determines which Node versions must be supported going forward.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rohit-sourcefuse rohit-sourcefuse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Engines and lockfile now match (22 || 24 both sides) and all checks are green. Approving — thanks for the quick turnaround.

@yeshamavani yeshamavani merged commit 22245b8 into master Jun 16, 2026
6 checks passed
@yeshamavani yeshamavani deleted the GH-287 branch June 16, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove Node.js 20 support

3 participants