Skip to content

refactor(chore): remove Node js 20 support#161

Merged
yeshamavani merged 1 commit into
masterfrom
GH-160
Jun 16, 2026
Merged

refactor(chore): remove Node js 20 support#161
yeshamavani merged 1 commit into
masterfrom
GH-160

Conversation

@Sourav-kashyap

Copy link
Copy Markdown
Contributor

remove Node js 20 support

BREAKING CHANGE:
yes

GH-160

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine

Build:

Screenshot 2026-06-11 at 3 09 15 PM

Test:

Screenshot 2026-06-11 at 3 09 30 PM

@Sourav-kashyap Sourav-kashyap self-assigned this Jun 11, 2026
@Sourav-kashyap Sourav-kashyap linked an issue Jun 11, 2026 that may be closed by this pull request

@rohit-sourcefuse rohit-sourcefuse left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 20 removal and the workflow/matrix changes look clean. One thing to fix before merge: package.json sets engines.node to "22 || 24", but the regenerated package-lock.json root still has ">=22" — the lockfile was generated before the engines value was changed and not re-run. Re-run npm install so they match.

Suggestion: standardize on ">=22" for a published library — "22 || 24" excludes Node 23 and every future LTS (26, 28…), so the package would refuse to install on the next LTS until another bump. Don't over-constrain consumers. Checks are green otherwise.

remove Node js 20 support

BREAKING CHANGE:
yes

GH-160
@sonarqubecloud

Copy link
Copy Markdown

SonarQube reviewer guide

Summary: Drop Node.js 20 support and bump to version 8.1.0, updating engine requirement to Node.js 22 or 24 only.

Review Focus: The main change is reducing Node.js version support from 20, 22, and 24 down to just 22 and 24. Verify this aligns with project requirements and that no dependencies have critical issues with Node.js 20 removal. The large package-lock.json changes reflect typical dependency updates; focus on any breaking changes in key packages like Helmet, Express, and LoopBack components.

Start review at: package.json. This is critical as it defines the engine requirement and version bump that drives all other changes. Confirm the new engine constraint is intentional and that it doesn't conflict with your project's support policy.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rohit-sourcefuse rohit-sourcefuse left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Engines and lockfile now match (22 || 24 both sides) and all checks are green. Approving — thanks for the quick turnaround.

@yeshamavani yeshamavani merged commit 3c1ea9a into master Jun 16, 2026
6 checks passed
@yeshamavani yeshamavani deleted the GH-160 branch June 16, 2026 10:19
@yeshamavani

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove Node.js 20 support

3 participants