Skip to content

refactor(chore): remove Node js 20 support#169

Merged
yeshamavani merged 1 commit into
masterfrom
GH-168
Jun 16, 2026
Merged

refactor(chore): remove Node js 20 support#169
yeshamavani merged 1 commit into
masterfrom
GH-168

Conversation

@Sourav-kashyap

Copy link
Copy Markdown
Contributor

remove Node js 20 support

BREAKING CHANGE:
yes

GH-168

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine

Build:

Screenshot 2026-06-11 at 2 55 28 PM

Test:

Screenshot 2026-06-11 at 2 55 47 PM

@Sourav-kashyap Sourav-kashyap self-assigned this Jun 11, 2026
@Sourav-kashyap Sourav-kashyap linked an issue Jun 11, 2026 that may be closed by this pull request

@rohit-sourcefuse rohit-sourcefuse left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 20 removal and the workflow/matrix changes look clean. One thing to fix before merge: package.json sets engines.node to "22 || 24", but the regenerated package-lock.json root still has ">=22" — the lockfile was generated before the engines value was changed and not re-run. Re-run npm install so they match.

Suggestion: standardize on ">=22" for a published library — "22 || 24" excludes Node 23 and every future LTS (26, 28…), so the package would refuse to install on the next LTS until another bump. Don't over-constrain consumers. Checks are green otherwise.

remove Node js 20 support

BREAKING CHANGE:
yes

GH-168
@sonarqubecloud

Copy link
Copy Markdown

SonarQube reviewer guide

Summary: This PR drops Node.js 20 support and updates the project to only support Node.js 22 and 24, along with dependency updates.

Review Focus:

  • Verify that dropping Node.js 20 support is intentional and aligns with project goals
  • Ensure all dependency updates maintain compatibility with Node.js 22 and 24
  • Check that audit.yml and main.yml workflow changes accurately reflect the new engine requirements

Start review at: package.json. This file contains the critical engine specification change from >=20 to 22 || 24, which defines the entire scope of this update. The version bump from 9.0.0 to 9.1.0 and engine change are the key changes that justify all downstream dependency updates in package-lock.json.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rohit-sourcefuse rohit-sourcefuse left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Engines and lockfile now match (22 || 24 both sides) and all checks are green. Approving — thanks for the quick turnaround.

@yeshamavani yeshamavani merged commit a016ec4 into master Jun 16, 2026
7 checks passed
@yeshamavani yeshamavani deleted the GH-168 branch June 16, 2026 10:03
@yeshamavani

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove Node.js 20 support

3 participants