Skip to content

Standardrb fixes - #6729

Merged
mamhoff merged 1 commit into
solidusio:mainfrom
SuperGoodSoft:fix-standardrb
Nov 8, 2026
Merged

mamhoff merged 1 commit into
solidusio:mainfrom
SuperGoodSoft:fix-standardrb

Conversation

@adammathys

Copy link
Copy Markdown
Member

Summary

Couple of issues snuck in from our security updates, since we can't automatically run standardrb on private forks.

This is just the result of running standardrb on the codebase and letting it fix the issues it found. (And removing one rubocop:disable comment.)

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

Couple of issues snuck in from our security updates, since we can't
automatically run standardrb on private forks.

This is just the result of running standardrb on the codebase and
letting it fix the issues it found.
@adammathys
adammathys requested a review from a team November 6, 2026 23:30
@github-actions github-actions Bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_storefront Changes to the storefront labels Nov 6, 2026
@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.58%. Comparing base (5ed0964) to head (093063d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6729   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files        1065     1065           
  Lines       21658    21658           
=======================================
  Hits        20053    20053           
  Misses       1605     1605           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjaminwil benjaminwil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This explains why my recent pull request was upset with me.

@jarednorman jarednorman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed this on main (but I think not the other branches) because I wasn't cutting a release, so I didn't run CI on main's octopus merge.

@mamhoff
mamhoff merged commit 6cbf0aa into solidusio:main Nov 8, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_storefront Changes to the storefront

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants