Skip to content

Make the BogusCreditCard test payment method more valuable - #6701

Merged
AlistairNorman merged 2 commits into
solidusio:mainfrom
benjaminwil:bogus-credit-card-enhancements
Oct 17, 2026
Merged

AlistairNorman merged 2 commits into
solidusio:mainfrom
benjaminwil:bogus-credit-card-enhancements

Conversation

@benjaminwil

Copy link
Copy Markdown
Contributor

Summary

I am currently working on the payment method configuration views for the new solidus_admin gem. I have found it valuable to have access to a test payment method that has uses all of the supported preference types that Solidus currently supports as I build out form components.

I can think of a few reasons this would be valuable to other developers:

  1. The bogus credit card method now provides better documentation for what payment methods can do out-of-the-box. This is advantageous to developers, but also to any admin user evaluating Solidus.
  2. It allows us to write browser integration tests for payment methods that actually use preferences. In the real world, most payment methods utilize preferences. But until now, our test payment methods didn't really.
  3. Like I implied earlier: anyone debugging or developing features in solidus_admin could benefit from a muscular test payment method.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@github-actions github-actions Bot added the changelog:solidus_core Changes to the solidus_core gem label Oct 16, 2026
@benjaminwil
benjaminwil force-pushed the bogus-credit-card-enhancements branch from 0aba606 to 01dce04 Compare October 16, 2026 21:18
@benjaminwil
benjaminwil marked this pull request as ready for review October 16, 2026 21:19
@benjaminwil
benjaminwil requested a review from a team as a code owner October 16, 2026 21:19
I believe the intent of this test file was to just make sure we hadn't
broken the payment method during framework development.
This allows framework developers to more easily test admin integration
with Solidus core.

The added preferences also act as better documentation for developers
starting a payment integration or admin users assessing how extensible
payment methods can be out-of-the-box.
@benjaminwil
benjaminwil force-pushed the bogus-credit-card-enhancements branch from 01dce04 to 13bc294 Compare October 16, 2026 21:38

@jarednorman jarednorman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this.

@AlistairNorman
AlistairNorman merged commit 5b47ff2 into solidusio:main Oct 17, 2026
41 checks passed
Noah-Silvera pushed a commit to SuperGoodSoft/solidus that referenced this pull request Nov 2, 2026
…enhancements

Make the `BogusCreditCard` test payment method more valuable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants