Repository navigation
Prevent destroying the default store - #6700
Merged
jarednorman merged 1 commit intoOct 17, 2026
Merged
jarednorman merged 1 commit into
jarednorman merged 1 commit into
Conversation
Spree::Store#validate_not_default ran as a before_destroy callback that added an error but never threw :abort, so the destroy went ahead and removed the default store. Prepend the callback so it runs before the dependent associations are destroyed and abort when the store is the default. Backport of bfee596 and 94f3b84 from solidusio#6589.
AlistairNorman
approved these changes
Oct 16, 2026
adammathys
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spree::Store#validate_not_default ran as a before_destroy callback that added an error but never threw :abort, so the destroy went ahead and removed the default store. Prepend the callback so it runs before the dependent associations are destroyed and abort when the store is the default.
Backport of bfee596 and 94f3b84 from #6589.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: