[jarednorman]

Summary

When a line item had inventory units, the validator counted pending units per stock location and checked line_item.variant against each count. This assumed every unit shared the line item's variant.

This assumption doesn't hold when stores use solidus_product_assembly or implement their own bundling systems. It also doesn't hold even without such customizations: ReturnItem#build_exchange_inventory_unit attaches a unit with the exchange variant to the original line item. This means that an exchange on an order that gets canceled and resumed (admittedly not a common thing) would get validated against the original variant's stock, not the exchanged variant. Technically a bug.

The InventoryUnitsFinalizer was fixed ages ago to unstock each unit's own variant. This change updates the validator to check stock the same way, against the inventory unit's variant.

For ordinary stores, this doesn't change anything. For stores that implement bundling or use solidus_product_assembly, we can simplify things. Previously Product Assembly replaced this whole class; after this it'll only have to make one small modification.

References:

• Discussion Availability Validator Improvement? #4489
• The finalizer was fixed in d3411e6
• https://jardo.dev/an-update-on-bundles-in-solidus

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I agree that my PR will be published under the same license as Solidus.
• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have localized any and all user-facing strings that I added to the source code.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.46%. Comparing base (78fb02b) to head (7487b9a).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6691   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files        1057     1057           
  Lines       21465    21467    +2     
=======================================
+ Hits        19848    19850    +2     
  Misses       1617     1617           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.