[AlistairNorman]

Index page titles and the order, payment and shipment state badges on the orders list were always shown in English. They now use the admin's locale.

Based on work by @nerijunior in #6419

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I agree that my PR will be published under the same license as Solidus.
• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have localized any and all user-facing strings that I added to the source code.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.47%. Comparing base (53f7015) to head (4246c21).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6685      +/-   ##
==========================================
+ Coverage   92.30%   92.47%   +0.16%     
==========================================
  Files         969     1056      +87     
  Lines       19847    21490    +1643     
==========================================
+ Hits        18319    19872    +1553     
- Misses       1528     1618      +90     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[benjaminwil]

We should be able to get the humanized string in different locales. It seems like we are just missing state machine translations. To test, I dropped in some additional translation strings and was able to see this work against an order record:

# en.yml
en:
  activerecord:
    state_machines:
      spree/order:
        states:
          complete: "EN translation"

# fr.yml
en:
  activerecord:
    state_machines:
      spree/order:
        states:
          complete: "FR translation"

I18n.with_locale(:en) do
  Spree::Order.first.human_state_name
end
# => "EN translation"

I18n.with_locale(:fr) do
  Spree::Order.first.human_state_name
end
# => "FR translation"

[AlistairNorman]

Right but then we would need to add all of those translations. I would rather use the existing translations because the alternatives are duplicating them or figuring out what uses the existing ones and moving it all over.

[benjaminwil]

We don't necessarily need to move them all over now.

I see an opportunity to centralize all of the state machine state translations in the YAML long term, while also reducing complexity of the new solidus_admin templates in the short term and promoting a nicer way to get translated states for application developers.

[AlistairNorman]

If we don't move them over then everything will still show in English which is what this is trying to solve so I copied the existing translations. It duplicates them all but we do get the nicer helper which we can use going forward

[benjaminwil]

Ah, sorry. By moving it all over I thought that you meant existing translations that should probably be moved over to the activerecord.statemachines.* prefixed strings.

Despite the duplication, I think this is valuable. 👍

[nerijunior]

Thanks @AlistairNorman