Skip to content

Rails main: Vendor rails-ujs.js - #6679

Merged
jarednorman merged 1 commit into
solidusio:mainfrom
SuperGoodSoft:vendor-rails-ujs
Oct 17, 2026
Merged

Rails main: Vendor rails-ujs.js#6679
jarednorman merged 1 commit into
solidusio:mainfrom
SuperGoodSoft:vendor-rails-ujs

Conversation

@jarednorman

@jarednorman jarednorman commented Oct 10, 2026

Copy link
Copy Markdown
Member

Summary

I guess it got removed from Rails 8.2.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@jarednorman
jarednorman requested a review from a team as a code owner October 10, 2026 23:31
@github-actions github-actions Bot added the changelog:solidus_core Changes to the solidus_core gem label Oct 10, 2026
@codecov

codecov Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.46%. Comparing base (78fb02b) to head (43312dc).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6679   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files        1057     1057           
  Lines       21465    21465           
=======================================
  Hits        19848    19848           
  Misses       1617     1617

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tvdeyen
tvdeyen approved these changes Oct 11, 2026
View reviewed changes

@tvdeyen tvdeyen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the reason to the commit message.

tvdeyen
tvdeyen reviewed Oct 14, 2026
View reviewed changes

@tvdeyen tvdeyen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to vendor this in solidus_backend?

@jarednorman
Vendor rails-ujs.js in solidus_core
43312dc 
Rails main dropped rails-ujs from Action View (rails/rails@6abacb3), but
the install generator, the dummy app and the storefront template all
still require it. Ship the file from core so those manifests keep
resolving. On Rails 8.1 and earlier it's identical to the copy Action
View ships.
@jarednorman

jarednorman commented Oct 17, 2026

Copy link
Copy Markdown
Member Author

We probably want to vendor this in solidus_backend?

Install generator's spree/backend/all.js template (lives in core) requires it and the storefront manifest also requires in it. Core is the lowest common denominator.

@jarednorman
jarednorman merged commit 198c66c into solidusio:main Oct 17, 2026
43 checks passed
@jarednorman
jarednorman deleted the vendor-rails-ujs branch October 17, 2026 05:39
@tvdeyen

tvdeyen commented Oct 17, 2026

Copy link
Copy Markdown
Member

We probably want to vendor this in solidus_backend?

Install generator's spree/backend/all.js template (lives in core) requires it and the storefront manifest also requires in it. Core is the lowest common denominator.

Got it. Thanks. Something for the agenda I guess.

@markokajzer markokajzer mentioned this pull request Oct 17, 2026
Closed
5 tasks done
Noah-Silvera pushed a commit to SuperGoodSoft/solidus that referenced this pull request Nov 2, 2026
@jarednorman @Noah-Silvera
Merge pull request solidusio#6679 from SuperGoodSoft/vendor-rails-ujs
d3802b8 
Rails main: Vendor rails-ujs.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes
@adammathys adammathys adammathys approved these changes
@benjaminwil benjaminwil benjaminwil approved these changes

Assignees

No one assigned

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jarednorman @tvdeyen @adammathys @benjaminwil