Fix/underscore account hostname#2898
Open
Pazuzzu wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to your PR.
Fixes #1839
The async connector fails with SSL hostname mismatch on Python 3.11+ when the account name contains underscores (e.g.
my_org_account), because the resulting hostname is rejected during TLS verification.I saw that it's already being discussed in #1839. @sfc-gh-dszmolka's test confirmed that both
_and-resolve to the same account.(I've seen that the official Snowflake docs also document this now in: https://docs.snowflake.com/en/user-guide/admin-account-identifier)
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This one-liner in
construct_hostname()normalizes underscores to hyphens before building the FQDN, same approach dbt-snowflake shipped in dbt-labs/dbt-snowflake#1068.Note: this reopens #2897, which was closed for administrative reasons unrelated to the code.