Render ALTER rows as a tree with per-change details in plan/deploy ou…#3071
Draft
sfc-gh-jsommerfeld wants to merge 9 commits into
Draft
Render ALTER rows as a tree with per-change details in plan/deploy ou…#3071sfc-gh-jsommerfeld wants to merge 9 commits into
sfc-gh-jsommerfeld wants to merge 9 commits into
Conversation
…tput Each ALTER row in `snow dcm plan` and `snow dcm deploy` output now expands into a child tree showing individual property changes, colored by operation (added/modified/removed) with only the keyword colored, not the full line. Children are sorted: added → modified → removed. - Expand ALTER rows with per-change detail lines indented as a tree - Color only the operation keyword on ALTER child lines - Sort nested ALTER children by kind - Drop kind-column padding on ALTER child rows (cleaner alignment) Co-authored-by: Cursor <cursoragent@cursor.com>
Map the 'changed' kind to ALTER_STYLE so it matches 'modified'/'renamed' and the top-level ALTER operation, instead of falling through to the unknown (blue) style. Co-authored-by: Cursor <cursoragent@cursor.com>
sfc-gh-jsommerfeld
force-pushed
the
feature/dcm-alter-detail-tree
branch
from
1aef3ca to
db1e79e
Compare
Collapse the two divergent blues — the periwinkle hex #a0a8fe (refresh status / unknown rows) and the terminal-default named "blue" (running phase, progress bar/spinner, analyze INFO findings / file headers) — onto one BLUE constant in styles.py, and route progress.py's hardcoded style="blue" literals through it, so every blue in DCM output renders the same hue. Co-authored-by: Cursor <cursoragent@cursor.com>
Modified properties under ALTER now render as `NAME: <prev> → <new>` (or `NAME = <value>` when only a new value is present). Long or multi-line values are collapsed to one line and truncated so the tree layout stays compact. Property names are uppercased and colored (terminal-default magenta/purple) to stand out from their values and the operation keyword. Co-authored-by: Cursor <cursoragent@cursor.com>
- Property values (set/changed) render blue; the separators stay neutral. - Property names render neutral (no longer magenta). - The "set" keyword renders neutral so it doesn't read as a creation. - A modified property's "→" renders in the ALTER color to split prev/new. - Top-level operation object names (the FQN) render magenta. Co-authored-by: Cursor <cursoragent@cursor.com>
Align refresh and test table-name columns with the plan/deploy top-level object name color (magenta). DOMAIN_STYLE was only ever used for object names, so it's folded into the shared OBJECT_NAME_STYLE. Co-authored-by: Cursor <cursoragent@cursor.com>
The set/changed value color was a named "blue" that didn't match the cyan hue object names used before. Switch VALUE_STYLE to cyan so values keep that recognizable color now that object names are magenta. Co-authored-by: Cursor <cursoragent@cursor.com>
The ALTER detail rows uppercase property names (e.g. EXPRESSION), so the nested-expectation test assertion and snapshot now expect the uppercased form. Co-authored-by: Cursor <cursoragent@cursor.com>
The top-level CREATE/ALTER/DROP keyword now renders bold so each entity row stands out (the shared styles stay non-bold for the sub-change keywords in the tree). A rendered tree is followed by a blank line separating it from the next entity; the final entity is skipped since the summary adds its own. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tput
Each ALTER row in
snow dcm planandsnow dcm deployoutput now expands into a child tree showing individual property changes, colored by operation (added/modified/removed) with only the keyword colored, not the full line. Children are sorted: added → modified → removed.Pre-review checklist
RELEASE-NOTES.md(see when and how).Changes description
...