Added XKCD substitutions 2 - #43
Open
IDisposable wants to merge 2 commits into
Open
Conversation
Automatically creates the lowercased version if it doesn't exist.
Contributor
Author
There was a problem hiding this comment.
The change in background.js make case-only differences redundant. It will match the upper-case version (and preserve) and because of the diversify method, it will ALSO match the lower-case and emit the lower-cased version of the replacement. Where there is already a different mapping, it is left in place... this specific instance would be redundant.
Owner
There was a problem hiding this comment.
I saw that wth the case insensitivity. I just didn't see the uppercase one anywhere. Derp. :P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See http://www.xkcd.com/1625/