Repository navigation
feat: exchange cockpit execution events with the DEV coordinator - #422
Merged
Merged
Conversation
A project whose own record names OpenRig and a DEV coordinator now tells that coordinator two things, each as one `rig send` line: a start or resume naming the project and the goal, sent after the start-next-phase write, and the person's gate answer naming the answer, the gate, and the subject, sent after the line is filed. The reply is returned under `coordinator` as coordinator status, apart from the phase and the gate status, and nothing it says reaches the gate record. A failed or empty send shows coordinator unreachable, and the gate answer stands because it was filed first. A project with no execution layer, or no DEV coordinator, sends nothing. No other seat is addressed, and an address that reads as an option is never handed to the transport. `gates file` output is unchanged; the cockpit path gets the gate digest from an internal helper. Part of #371. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rig send exiting 0 is delivery only. Coordinator status is a reply, or null when none came back.
A send that exits 0 is delivery. Coordinator status is only a reply from the coordinator.
Owner
Author
|
Operator acceptance on behalf of @smota: Verified high-assurance scope in PR #422 for #421. Clean separation between transport delivery ('delivered' vs 'coordinator unreachable') and coordinatorStatus (null unless non-empty reply returned). Gate decisions stand even if coordinator unreachable. Test suite passes. Approved for merge upon CI completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only a project that names OpenRig sends to its DEV coordinator. The cockpit sends a start or resume, and the person's gate answer. Delivery says whether the message reached the coordinator. A send that exits 0 is delivery, not a reply. Coordinator status is only what the coordinator replied, and it stays empty when none came back. It is not the phase and not the gate. A coordinator message cannot move a gate. If the coordinator cannot be reached, the gate answer still stands. A project with no execution layer sends nothing.
High-assurance. Do not merge until a person accepts this pull request. Tests used a fake coordinator, not a live rig.
Implemented issues
Implements #421
Related issues
Refs #371
Refs #379
Workflow evidence
CI-equivalent validation
pnpm exec vitest run lib/__tests__/cockpit-coordinator-events.test.mjsand the fullpnpm testreported by dev.qa.Agent review
Role attribution matrix
Follow-up issues
None. No live coordinator was called. #379 stays the note. Human acceptance of this pull request is required before merge.