feat: add accept_numeric kwarg to ToCategorical - #2252
Draft
lisaleemcb wants to merge 4 commits into
Draft
Conversation
rcap107
reviewed
Aug 25, 2026
rcap107
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR @lisaleemcb! There are still a few things that we need to clarify, but here is an early review with some comments
Contributor
Author
|
Note this PR is still failing because of the test case where the integer column contains None/null values. This desired behaviour in this situation is still tbd, and should be discussed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encoder
ToCategoricalnow also accepts typeintcolumns, in addition tostrand categorical dtypes via setting the new kwargaccept_numericto'int'. In addition,floatcolumns will be accepted ifaccept_numeric='all'.As currently implemented, the new default is
accept_numeric='int'which means that columns of strings, categoricals, and ints will be marked as categorical after performingfit_transform. Note this is different from the current default behaviour, which only accepts strings, and categoricals, and will raise an error otherwise. The current default can be recovered by settingaccept_numeric=None.The rationale for the new default is that integers are used in many datasets to represent categories. But this would make it a breaking change for direct users, so perhaps we should discuss.
However, note that this change in the default would not affect the behaviour of the
TableVectorizer, as the numerical columns are currently not selected to be sent to theToCategoricalencoder. Thanks to @rcap107 for beaucoup help with understanding its behaviour.PS Also changed the docstring to make it more concise.