Mirror AgentScope #2796 for JAIPilot Cloud - #1
Open
skrcode wants to merge 1 commit into
Open
Conversation
The shared static victools SchemaGenerator is not thread-safe: its JacksonModule keeps an unsynchronized introspection cache, so concurrent structured calls can fail with ConcurrentModificationException. Guard both schemaGenerator.generateSchema(...) call sites with a dedicated lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact mirror of agentscope-ai#2796 at head 15859a9.
Evaluation context: this change restores thread safety by serializing every schema generation through one global lock. Look only for a small behavior-preserving improvement within the changed production path that reduces avoidable lock contention or work. Preserve schema bytes, exception behavior, and thread safety. Independently benchmark or count the relevant operation under comparable conditions; keep no change if the benefit cannot be proved.