Added unbound DisclosureGroup constructors and fixed animated updates - #507
Open
fhasse95 wants to merge 1 commit into
Open
Added unbound DisclosureGroup constructors and fixed animated updates#507fhasse95 wants to merge 1 commit into
fhasse95 wants to merge 1 commit into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for using
DisclosureGroupwithout an externalisExpandedbinding. When no binding is provided,DisclosureGroupnow manages its expansion state internally, similar to other controls likePicker.Example:
It also fixes
DisclosureGroupanimations when used insideFormandList. As part of this,Listnow uses stable row and section keys for animated updates, fixing the visual artifacts that could appear when rows were inserted or removed. This improves not only expanding and collapsingDisclosureGroups, but also animatedListupdates in general, for example when rows are inserted or removed during an animated state change.The behavior after the bugfix can be verified in the
FormPlaygroundof the Skip Showcase app:Before:

After:

Related PR:
Thank you for contributing to the Skip project! Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Skip Pull Request Checklist:
swift testThe initial implementation was generated with assistance from Codex. The resulting code was manually reviewed, refined where necessary, and validated using my own app on iOS, iPadOS, macOS (Catalyst), and Android to ensure correctness and consistent cross-platform behavior.