Allow accent color lookup to use supplied bundle - #504
Open
haaaaaaarshs wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a bundle-passing path for the Android
AccentColorasset lookup so that callers are no longer limited to searchingBundle.main.Issue #431 describes an
AccentColorresource that may belong to an application's module bundle. However,Color.assetAccentColorcurrently searches onlyBundle.main, preventing resources stored in another bundle from being found.Changes
Color.assetAccentColorto accept a suppliedBundle.AssetKeycache key and theassetColorInfolookup.ColorScheme.asMaterialThemeto accept and forward anaccentColorBundle.PresentationRootto accept and forward the accent-color bundle.Bundle.mainas the default for backward compatibility.Architectural note
This PR establishes the SkipUI-side path needed to supply the application's resource bundle to the accent-color lookup.
A generated application template or another application entry point may still need to pass its module bundle, such as
.module, intoPresentationRoot. I previously asked on Issue #431 whether that final integration should live in the generated template,ComposeContext, or another shared rendering mechanism.I am submitting the implementation for review so the maintainers can determine the preferred integration point and whether a companion change is needed elsewhere.
Testing
git diff --checkswift testTest results:
Related to #431
Skip Pull Request Checklist
swift test