Support for SkipFuseUI Animation Performance Fix (Android) - #500
Open
tifroz wants to merge 8 commits into
Open
Conversation
- preserve ForEach and stack composition identity - improve equatable content caching and bridge equality - support explicit first-render animation sources - prevent animation provenance from leaking between modifiers - document Android rendering performance APIs
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Skip project! Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Skip Pull Request Checklist:
swift testCodex generated the code with supervision, UI tests conducted manually to validate performance improvements
Summary
This PR supports the SkipFuseUI addition of
.androidEquatable()and.androidCompositionBoundary()APIs to protect UI view subtrees from excessive recomposingForEachchild identity through stack insertions, removals, and reordering.Testing
AndroidEquatableTestscoverage for unchanged and changed cache keys,ForEachidentity, lazy stacks, environment values, hoisted state, actions, and bridged factories.Usage Example
For non-
Equatableviews, provide an explicit cache key:Use a retained composition boundary when a subtree needs separate hosting:
API Shape
The bridge surface also gains lazy
AndroidEquatableContent,AndroidCompositionBoundaryprojection lifecycle support, compositor transforms, and experimental first-render helpers for frame, offset, opacity, and scale.Notes
SkipFuseUI skiptools/skip-fuse-ui#134 depends on this PR