Add support and documentation for data-only (silent) push notifications - #97
Merged
marcprux merged 3 commits intoJul 22, 2026
Merged
Conversation
Contributor
Author
|
I should add that I did use Claude Fable to discuss some design ideas and changes and to assist with debugging, but the code is strongly vetted and tested by me personally, and only a very small portion of it was actually generated at all. |
Member
|
Nice addition, and good docs, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Skip Pull Request Checklist:
swift testHello!
We at RSPNDR are dealing with Data-Only push notifications lately and have been unfortunately blocked by Skip's missing support for this. When the "notification" property (for example for the title and body of a push notification) is missing, the
onMessageReceivedfunction performs an early return which ignores the notification.For us on the iOS side, this is working perfectly fine but requires an additional application delegate function to be implemented, so I've added some details in the documentation regarding this, including some notes about the possible requirement to disable swizzling.
On the Android side, I have implemented an additional custom "Messaging" didReceiveRemoteMessage function which is only triggered ever in the Android app. It didn't seem at all possible to make use of the UserNotificationCenter, so I hope this is an acceptable side step.
I have tested thoroughly that background notifications are indeed working on both iOS and Android, and the original banner-style push notifications are still working as originally designed.
Closes #86