Repository navigation
fix(import): send PCAP INSERT through node /exec (11.0.337) - #994
Merged
Merged
Conversation
POST /query stays read-only. Coordinator writes use an authenticated /exec path that only allows INSERT INTO <catalog>.main.hep_proto_* VALUES. Fixes #993.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /queryread-only (GHSA-rm5w-rqr7-2h54). PCAP import now writes via authenticatedPOST /exec.ValidateWriteSQLallows onlyINSERT INTO <catalog>.main.hep_proto_* (...) VALUES ...— noSELECT/FROM, system catalogs, quoted identifiers, or statement stacking.VERSION_APPLICATIONto 11.0.337.Fixes #993
Test plan
go test ./coordinator/sqlvalidator/ ./node/ ./coordinator/services/ ./coordinator/handlers/POST /api/v4/imports/pcapon an all-in-one DuckLake node imports SIP instead of 400got "INSERT"POST /querystill rejectsINSERT/DROP/read_text()