Tap mambu sync - do not truncate bookmark date for filter#32
Open
gvillafanetapia wants to merge 22 commits into
Open
Tap mambu sync - do not truncate bookmark date for filter#32gvillafanetapia wants to merge 22 commits into
gvillafanetapia wants to merge 22 commits into
Conversation
Contributor
|
Hi @gvillafanetapia, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
Contributor
|
You did it @gvillafanetapia! Thank you for signing the Singer Contribution License Agreement. |
Author
|
Related issue #31 |
* add transaction_channels (v2) * add paginate flag
Merge v2.1.1
Gl journal entries fix
gl_journal_entries Fix bookmark field
Gl journal entries tz fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
When calling Mambu API; send timezone aware datetime to filter
creationDateAFTERThis way no matter what timezone is configured on the Mambu side, the API will interpret the filter correctly.
Manual QA steps
Risks
Rollback steps