Skip to content

feature: allow reading RHACK_DIR from .cargo/config.toml files.#9

Open
seivan wants to merge 2 commits into
simonsan:mainfrom
seivan:feature/config
Open

feature: allow reading RHACK_DIR from .cargo/config.toml files.#9
seivan wants to merge 2 commits into
simonsan:mainfrom
seivan:feature/config

Conversation

@seivan

@seivan seivan commented Jul 18, 2024

Copy link
Copy Markdown

Search order:

  1. $RHACK_DIR
  2. .cargo/config.toml
  3. $CARGO_HOME/config.toml

Order: `RHACK_DIR` env variable, local `.cargo/config.toml`, `$CARGO_HOME/config.toml`.
@simonsan

simonsan commented Nov 4, 2024

Copy link
Copy Markdown
Owner

Will review later today, thank you for the PR, and sorry for the delay. 👍🏽

@seivan

seivan commented Nov 29, 2024

Copy link
Copy Markdown
Author

@simonsan Any updates?

@simonsan

Copy link
Copy Markdown
Owner

@simonsan Any updates?

Wtf, sorry I totally forgot. Will do it in the evening!

@simonsan

Copy link
Copy Markdown
Owner

Ok, I was looking into it. Could you say a bit about the value reading the .cargo/config.toml gives? My intention was to migrate it to abscissa and have a usual configuration within a directory according to directories project-dir. So I'm not entirely sure about this, but happy to be explained what it is making better.

@seivan

seivan commented Nov 29, 2024

Copy link
Copy Markdown
Author

Ok, I was looking into it. Could you say a bit about the value reading the .cargo/config.toml gives?

It reads a path to store the "hacks". This makes sure you can define it in your projects Cargo.toml or use a global config like $CARGO_HOME.

Right now it puts all of them in a single place. This lets you have a per project setting if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants