build: run the build when installed from git - #47
Open
Joilence wants to merge 1 commit into
Open
Conversation
`dist/` is gitignored and `main` points at `./dist/index.js`, so installing this package from a git URL produced a package whose entry point did not exist. npm installs devDependencies and runs `prepare` for git dependencies, and typescript is already a devDependency, so the build just needs to be wired to that lifecycle hook. Installing from the npm registry is unaffected: the published tarball already ships `dist/`, and `prepare` does not run for registry installs of a packed tarball.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainpoints at./dist/index.js, butdist/is gitignored. A git install therefore has no entry point:Installs from npm are fine, since the tarball ships
dist/viafiles. That is the only path CI covers.What
+ "prepare": "npm run build",npm runs
preparefor git dependencies after installing devDependencies, andtypescriptis already one. Tarball installs skip it, so npm users see no change.Test
Same git URL both ways: without the fix
dist/is missing and the CLI crashes, with itargo --versionprints0.39.1. Suite: 753 pass.Note:
npm installhere now builds too, so CI builds twice.