SG-45254 Drop Python 3.7/3.8 compat from build tooling (keep 3.9) - #88
Draft
julien-lang wants to merge 1 commit into
Draft
julien-lang wants to merge 1 commit into
julien-lang wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments; the changes retain Python 3.9 support.
Pull request overview
Updates tk-toolchain to support Python 3.9+ while removing obsolete Python 3.7/3.8 compatibility.
Changes:
- Raises the minimum Python version and updates classifiers through Python 3.13.
- Simplifies Sphinx dependencies and removes the obsolete Jinja2 pin.
- Updates the Python intersphinx documentation target.
File summaries
| File | Description |
|---|---|
tk_toolchain/cmd_line_tools/tk_docs_generation/sphinx_data/conf.py |
Updates the Python documentation reference. |
setup.py |
Updates Python requirements, dependencies, and classifiers. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 48.95% 48.95%
=======================================
Files 19 19
Lines 721 721
=======================================
Hits 353 353
Misses 368 368
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tk-toolchainstill carried Python 3.7/3.8 compatibility shims and stale classifiers, left over from before those versions were dropped.Changes
python_requires:>=3.7.0->>=3.9.0(drop 3.7/3.8, keep 3.9).sphinx==7.0.0(thesphinx==5.3.0fallback only existed for Python < 3.9).jinja2==3.0.3pin (it only existed for the old sphinx / py<3.9 path; sphinx 7 works with modern jinja on 3.9+).import sys(it was only used by the removed sphinx version conditional).3.7, keep3.9/3.10/3.11, add3.13.conf.pyintersphinx: link Python docs3.9->3.10.Why keep 3.9
CI still runs the Python 3.9 jobs (per SG-40695 we keep testing 3.9 for compatibility as long as possible), and
tk-toolchainispip install-ed into every CI job including those. So it must remain installable on 3.9 -python_requiresstays at>=3.9.0, not>=3.10.Notes
Related