SG-45235 Remove obsolete Python 2-era vendored unit-test dependency system - #1134
Open
julien-lang wants to merge 2 commits into
Open
julien-lang wants to merge 2 commits into
julien-lang wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Removes obsolete Python 2-era vendored test dependency scaffolding and dead path references.
Changes:
- Deletes legacy dependency files and updater documentation.
- Removes obsolete
third_partypath entries. - Cleans related ignore rules and test documentation.
File summaries
| File | Description |
|---|---|
tests/run_tests.py |
Removes obsolete vendored path insertion. |
tests/README.md |
Removes outdated setup instructions. |
tests/python/upgrade_third_party.sh |
Deletes unused updater script. |
tests/python/requirements.txt |
Deletes obsolete dependency list. |
tests/python/README.md |
Deletes obsolete dependency documentation. |
tests/integration_tests/run_integration_tests.py |
Removes obsolete PYTHONPATH entry. |
.gitignore |
Removes obsolete ignore rule. |
.gitattributes |
Removes obsolete attribute rule. |
Review details
- Files reviewed: 7/8 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1134 +/- ##
==========================================
+ Coverage 80.09% 80.11% +0.02%
==========================================
Files 203 203
Lines 19537 19537
==========================================
+ Hits 15649 15653 +4
+ Misses 3888 3884 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
julien-lang
marked this pull request as ready for review
September 15, 2026 20:20
julien-lang
requested review from
a team,
carlos-villavicencio-adsk,
stevelittlefish and
yungsiow
and removed request for
yungsiow
September 15, 2026 20:20
stevelittlefish
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tk-corecarried a vendored third-party unit-test dependency system, a legacy standalone test runner, and a Python 3 compile-check that have all been dead for years. They were leftover scaffolding from a half-finished 2023 cleanup and only confused anyone touching the test setup.Background
The
tests/python/third_partymechanism dates back to 2017 and was a Python 2-era design: test dependencies (coverage,unittest2,mock,setuptools) were committed into the repo so the suite could run under the pip-less Python shipped with Desktop. In 2023 the committedthird_party/folder was deleted and gitignored, and testing moved to pytest + pip viatk-toolchain, but the surrounding scaffolding, the legacyrun_tests.*runner, and thecompile_python3.*scripts were never removed. None of them are referenced by CI (tk-ci-tools) orazure-pipelines.yml.Changes
tests/python/requirements.txt,tests/python/upgrade_third_party.sh, andtests/python/README.md.third_partysys.pathinsertion intests/run_tests.pyand thePYTHONPATHentry intests/integration_tests/run_integration_tests.py.tests/python/third_partyentries from.gitignoreand.gitattributes.unittestrunner:tests/run_tests.py,run_tests.sh,run_tests.bat.tests/compile_python3.sh/compile_python3.batPython 3 compile-check.tests/README.mdto document running the suite withpytestviatk-toolchain.No functional change: CI already runs the tests via pytest with pip-installed coverage, and the removed paths/scripts were inert or unreferenced.
Testing
pre-commitpasses on the changed files.Related
tk-toolchainchange: SG-45235 Remove vendored-test-deps references (dead third_party ignore, coverage pin) tk-toolchain#86