refactor: replace wazero and php wasm binaries with go-phplint#1261
Open
Soner (shyim) wants to merge 2 commits into
Open
refactor: replace wazero and php wasm binaries with go-phplint#1261Soner (shyim) wants to merge 2 commits into
Soner (shyim) wants to merge 2 commits into
Conversation
- Replace wazero and PHP WASM binary downloads with github.com/shyim/go-phplint v0.2.0 - Delete internal/phplint package and execute phplint directly in internal/extension/platform.go - Remove entitlements.xml and notarize entitlements configuration in .goreleaser.yaml - Reduce binary size by ~2 MB and speed up PHP linting without network dependencies Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
==========================================
+ Coverage 53.63% 53.79% +0.15%
==========================================
Files 303 300 -3
Lines 23325 23243 -82
==========================================
- Hits 12511 12504 -7
+ Misses 10787 10712 -75
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
wazeroWebAssembly runtime and externalphp-*.wasmbinary downloads withgithub.com/shyim/go-phplint(v0.2.0).internal/phplintpackage entirely, callinggo-phplintdirectly insideinternal/extension/platform.go.entitlements.xmland removed the macOS code signing entitlements configuration from.goreleaser.yaml(since JIT/executable memory permissions are no longer required withoutwazero).SHOPWARE_CLI_DISABLE_WASM_CACHEfrom GitHub Actions workflow.Why?
internal/phplintwrapper package and extra entitlement files.How was this tested?
go test ./...and verified all test suites pass../scripts/run-tests.sh.Related issue or discussion
N/A