Skip to content

Document Nix attribute style convention - #408

Merged
shikanime merged 1 commit into
mainfrom
chore/agents-nix-style
Sep 10, 2026
Merged

shikanime merged 1 commit into
mainfrom
chore/agents-nix-style

Conversation

@shikanime

@shikanime shikanime commented Sep 10, 2026

Copy link
Copy Markdown
Member

What

Documents the Nix attribute-style rule in AGENTS.md: dotted assignment (a.b.c = v;) for a single leaf under a shared parent key; a record literal once two or more keys share that parent, with keys sorted.

Why

The convention previously lived only in the machines repo and drove review churn elsewhere; every Nix-touching repo now carries the same rule.

References

Related: shikanime-labs/machines#1315

Co-authored-by: Automata automata@shikanime.studio

Summary by CodeRabbit

  • Documentation
    • Added Nix formatting guidance covering dotted assignments, record literals, and key ordering.

Co-authored-by: Automata <automata@shikanime.studio>
Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio>
Change-Id: Idf12382be3522d1e1a915f189847a3ff6a6a6964
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 311af6a2-6182-4598-b1bd-402e0a7f70ee

📥 Commits

Reviewing files that changed from the base of the PR and between 8825fcd and 7a92d86.

📒 Files selected for processing (1)
  • AGENTS.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

AGENTS.md now documents Nix formatting rules for single leaf assignments, multi-key record literals, and sorted keys.

Changes

Nix formatting guidance

Layer / File(s) Summary
Document Nix style rules
AGENTS.md
Adds guidance to use dotted assignments for single leaf values, record literals for multiple keys under one parent, and sorted keys.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7a92d

This documentation-only change has no runtime or production impact and is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: documenting the Nix attribute-style convention.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/agents-nix-style

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shikanime
shikanime merged commit 78b7c85 into main Sep 10, 2026
5 checks passed
@yorha-automata
yorha-automata Bot deleted the chore/agents-nix-style branch September 10, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant