docs: clarify --silent flag doesn't suppress exit codes#249
Merged
Conversation
Fixes shelljs#208. The --silent flag only suppresses error output, not the exit code. Add an example showing how to combine --silent with '|| shx true' to also ignore the exit status.
Closed
Contributor
Author
|
Hi @shelljs/maintainers, gentle ping on this --silent docs clarification. Let me know if anything needs changing! 🙏 |
Contributor
Author
|
Hi! Just checking in on this PR. It's been about 9 days since the last update. Is there anything I can do to help move this forward? 🙏 |
Contributor
Author
|
Friendly ping! 😊 This PR has been waiting for review for 5+ days and the 7-day spam-control threshold is approaching (2026-05-20). Just wanted to make sure this didn't slip through. Let me know if you need any changes! |
Contributor
Author
|
👋 Hi maintainers, just checking in on this PR. Is there anything I can do to help move it forward? |
Contributor
Author
|
Hi! Just checking in — this PR has been open for 30+ days with no review. Happy to make any adjustments if needed. Thanks! 🙏 |
nfischer
approved these changes
Jun 6, 2026
Member
|
Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarifies that the
--silentflag only suppresses error output, not the exit code. Users in #208 expected--silentto also suppress exit codes, leading to confusion in npm scripts.Changes
Added one line to the README Usage example:
This follows the exact suggestion from the maintainer in #208.
Related
Fixes #208