fix: surface SpotBugs analysis failures#34
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf5b18964c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (projectResults.every((result) => !result.error)) { | ||
| args.diagnostics.replaceAll(aggregated); |
There was a problem hiding this comment.
Update diagnostics even when workspace projects fail
Gatekeeping replaceAll on projectResults.every((result) => !result.error) leaves diagnostics stale whenever any project fails, even if other projects analyzed successfully and produced new findings. In a mixed-success workspace run, the tree is refreshed from projectResults but editor diagnostics keep the previous run’s data, so users can miss fresh findings (or keep seeing obsolete ones) for the successful projects.
Useful? React with 👍 / 👎.
bf5b189 to
101f4d8
Compare
🤖 I have created a release *beep* *boop* --- ## [0.5.2](v0.5.1...v0.5.2) (2026-05-08) ### Bug Fixes * surface SpotBugs analysis failures ([#34](#34)) ([72da785](72da785)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
No description provided.