Skip to content

fix: surface SpotBugs analysis failures#34

Merged
shblue21 merged 1 commit into
mainfrom
fix/spotbugs-analysis-failure-envelope
May 4, 2026
Merged

fix: surface SpotBugs analysis failures#34
shblue21 merged 1 commit into
mainfrom
fix/spotbugs-analysis-failure-envelope

Conversation

@shblue21

@shblue21 shblue21 commented May 3, 2026

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf5b18964c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +154 to +155
if (projectResults.every((result) => !result.error)) {
args.diagnostics.replaceAll(aggregated);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update diagnostics even when workspace projects fail

Gatekeeping replaceAll on projectResults.every((result) => !result.error) leaves diagnostics stale whenever any project fails, even if other projects analyzed successfully and produced new findings. In a mixed-success workspace run, the tree is refreshed from projectResults but editor diagnostics keep the previous run’s data, so users can miss fresh findings (or keep seeing obsolete ones) for the successful projects.

Useful? React with 👍 / 👎.

@shblue21 shblue21 force-pushed the fix/spotbugs-analysis-failure-envelope branch from bf5b189 to 101f4d8 Compare May 4, 2026 01:49
@shblue21 shblue21 merged commit 72da785 into main May 4, 2026
7 checks passed
@shblue21 shblue21 deleted the fix/spotbugs-analysis-failure-envelope branch May 4, 2026 02:15
shblue21 pushed a commit that referenced this pull request May 8, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.5.2](v0.5.1...v0.5.2)
(2026-05-08)


### Bug Fixes

* surface SpotBugs analysis failures
([#34](#34))
([72da785](72da785))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant