Repository navigation
build: set the native-image javaLauncher with Property.set [NOTASK] - #1291
Merged
Merged
Conversation
The Groovy `javaLauncher = ...` assignment fails on native-build-tools 1.x: the generated setter casts the launcher property to LazyGroovySupport, and 1.x returns a dynamic proxy that does not implement it. `.set(...)` works on both the current 0.11.5 and 1.x, so this unblocks the plugin bump without changing behaviour today. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
stefanoboriero
approved these changes
Nov 19, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Set the native-image
javaLauncherwithProperty.set(...)instead of the GroovyjavaLauncher = ...assignment.Why
The Groovy assignment form fails at configuration time on native-build-tools 1.x:
In 1.x
getJavaLauncher()returns a dynamic proxy rather than a plain GradleProperty— added by native-build-tools#845 to distinguish an explicitly configured launcher from a convention one. Gradle's generated setter for the=sugar casts the receiver toLazyGroovySupport, which the proxy does not implement. Known upstream bug, still open: native-build-tools#1071..set(...)is valid on the current 0.11.5 as well, so this is a no-op for today's build and unblocks the plugin bump in #1278 (Renovate will rebase that PR once this lands). Not "closes" — #1278 does the bump itself.Verification
./gradlew checkpasses; theapp:nativeCompiletask graph configures..set(...)form was additionally exercised end to end on both 0.11.5 and 1.1.18 locally — native image builds, andwave --version/--help/--dry-run -i alpine -o jsonall work — but only with the toolchain vendor spec relaxed to GraalVM CE, since Oracle GraalVM is not installed on that machine.Wave-cli buildsrun, which compiles the native binary with Oracle GraalVM 25 on all five matrix entries (incl. the static musllinux-x86_64build and the embedded trust store check).🤖 Generated with Claude Code