Repository navigation
[FEATURE] PHIBF - #596
Open
smehringer wants to merge 8 commits into
Open
[FEATURE] PHIBF#596smehringer wants to merge 8 commits into
smehringer wants to merge 8 commits into
Conversation
Closed
seqan-actions
added
lint
Member
|
Documentation preview available at https://docs.seqan.de/preview/seqan/raptor/596 |
smehringer
force-pushed
the
phibf_rebased
branch
from
October 20, 2026 10:28
ca14ce2 to
1a3df95
Compare
eseiler
self-requested a review
October 26, 2026 12:33
seqan-actions
added
lint
eseiler
force-pushed
the
phibf_rebased
branch
from
October 26, 2026 17:36
e90e5a4 to
8ff25bf
Compare
seqan-actions
added
lint
…_test icpx 2025.0 (and Clang 19) crash in SemaOpenMP::isOpenMPCapturedDecl when a function references a namespace-scope structured binding while OpenMP is enabled, which hibf always does. Make the user bins and the queries static members of the fixture; the queries become a small struct. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
search_partitioned_hibf wrote the timings after every part, even without --timing-output. The wall clock timer is still running at that point, so its in_seconds() is 0 and cpu_usage_in_percent fails `assert(elapsed_time_in_seconds > 0.0)` in Debug builds. Timings are now written only at the end, by search_parsing.cpp when --timing-output is set; the timers are no longer reset between parts and report totals over all parts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
seqan-actions
added
lint
Member
|
I changed CPM to use your chopper branch and the hibf lib with the wyhash merge. |
seqan-actions
added
lint
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
+ Coverage 96.16% 96.18% +0.02%
==========================================
Files 68 69 +1
Lines 2657 2750 +93
Branches 53 56 +3
==========================================
+ Hits 2555 2645 +90
- Misses 102 105 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft.
Missing: