Skip to content

fix: workaround broken ld on ubsan #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eseiler merged 1 commit into from
Oct 12, 2026
Merged

fix: workaround broken ld on ubsan #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/cron_sanitizer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ jobs:
- name: "UBSan"
os: macos-latest
cxx_flags: "-fno-omit-frame-pointer -fsanitize=undefined,float-divide-by-zero,implicit-conversion,local-bounds,nullability -Wno-pass-failed"
# Apple's ld from Command Line Tools 26.6 writes an __unwind_info that does not cover the last function of
# layout_validate_snippet; its exception terminates with "libunwind: malformed __unwind_info".
# Remove once macos-latest ships a fixed ld (Command Line Tools 27.0 works).
ldflags: "-fuse-ld=lld"

- name: "UBSan"
os: macos-latest
Expand Down Expand Up @@ -90,6 +94,9 @@ jobs:
- name: Configure tests
run: |
mkdir build && cd build
if [[ -n "${{ matrix.ldflags }}" ]]; then
export LDFLAGS="${LDFLAGS:-} ${{ matrix.ldflags }}"
fi
cmake ../test/all -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} \
-DCMAKE_CXX_FLAGS="${{ matrix.cxx_flags }}"
make gtest_main benchmark_main
Expand All @@ -101,4 +108,3 @@ jobs:
- name: Run tests
working-directory: build
run: ctest . -j --output-on-failure --no-tests=error ${{ matrix.ctest_excludes }}

Loading