Repository navigation
Replacing hostile with first-party solution - #1734
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 535987b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
approved these changes
Sep 30, 2026
askoufis
left a comment
Contributor
There was a problem hiding this comment.
Neat! Just one non-blocking suggestion.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used hostile to modify the users hosts entries in the
sku setup-hostscommand. It's been useful, but it contains a CLI which sku does not need. Since sku only uses hostile for adding entries to hosts and doesn't need all of its more complex logic, we can roll our own implementation pretty simply while fixing a few quirks.What changed
hostilerewrote every entry line in the file.setup-hostsshows a warning. The warning is needed since the existing line may take precedence over the line that sku appends and I don't want to silently overwrite it.sku startnow waits forcheckHoststo finish before it continues.checkHostsfinds hosts on lines that contain more than one host name, for example127.0.0.1 a.test b.test. Before this change,checkHostsshowed a false "not configured" warning for these hosts, unless the host name ended in.localhost.Setting up new hosts

All entries exist

Conflicting IPs
