fix: stabilize pilot installation and dependency builds - #107
Open
ericpaulsen wants to merge 3 commits into
Open
ericpaulsen wants to merge 3 commits into
ericpaulsen wants to merge 3 commits into
Conversation
14 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pilot setup mixed required installation with optional capture and maintainer release checks. Order the guides around prerequisites, configuration, startup, verification, and enrollment, following Coder's installation structure. Shorten the quickstart and move hook details after setup.
Fix pinned checkout and upgrade steps, per-client credentials, CLI installation, environment loading before agent startup, API readiness retries, gateway configuration before startup, and Session verification. Keep the synthetic rehearsal in the release guide; installing an approved build uses its release evidence plus live deployment checks. Preserve the rehearsal's executable documentation tests at its new location.
Fresh client installations also resolved unreviewed SQLAlchemy 2.1, and Wolfi's
OpenSSL transition broke gateway builds. Bound SQLAlchemy to 2.0 and pin the
gateway's existing reviewed OpenSSL and supporting packages. No security gates
or exceptions change.
Closes #106
Architecture check
Documentation, documentation-test paths, and dependency constraints change. No domain behavior, schema, or security policy changes.
Checklist
Shim changes, library logging, and cloud-import checks are not applicable.
Remaining release blockers
docs/operate/security.md. The manual security run collected both architectures and preserved the failing gates. The client check passes; image builds succeed, but disposition fingerprints and the gateway support-policy conflict block security acceptance.Notes for reviewers
Independent reviews checked command order and claims against the implementation. Fixed the environment reload and container-test scope findings. The quickstart test needed the host's existing libpq tools on PATH. Live pilot deployment, real agent capture, and a full release rehearsal were not exercised locally.
An independent review confirmed the dependency fixes preserve security checks and verified the unresolved upstream compatibility constraint. CI is not green.