Support php-wasm-builder output in external worktrees - #107
Draft
seanmorris wants to merge 3 commits into
Draft
seanmorris wants to merge 3 commits into
seanmorris wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
php-wasm-builder buildtarget parsing across web, node, worker, webview, base, CGI, CLI, and DBG outputs, with conflict validation and propagated Make failures.PHP_VERSIONthrough the Emscripten module environment.Why
The installed builder runs Make from its own repository while users configure output paths relative to another project. Those two roots were mixed together, which could double-prefix paths, write stdlib and preload output into the builder checkout, or omit the runtime package files an external build needs. The CLI also launched Make asynchronously and accepted ambiguous selectors, hiding failures and target mistakes.
Impact
External projects can build all supported runtime package variants into their own tree, use relative preload and asset paths consistently, and receive the actual Make exit status. This is independent of the Emscripten 6/dynamic-library update in #106 and does not duplicate that patch.
Checks
node --test test/builder-help.test.mjs test/builder-worktree.test.mjs test/preload-assets.test.mjs test/runtime-env.test.mjs— 18 passednpm run test:docs— 3 passed, 1 expected skipnpm run tsc— passedgit diff --check— passed