Skip to content

Rename output_file_path to output_folder_path for sample_from_conditions() and sample_remaining_columns() #2994

Description

@R-Palazzo

Environment Details

  • SDV version: SDV 2.0 feature branch

Problem Description

As part of the new sampling I/O, output_file_path was renamed to output_folder_path. However, sample_from_conditions() and sample_remaining_columns() still use the old parameter name.

Expected behavior

Rename output_file_path to output_folder_path in these methods to keep the sampling API consistent.

Additional context

Fixed in #2976.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions