Skip to content

invalidate UI render instance cache when freeing model instances #7514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Goober5000 merged 1 commit into from
Jun 9, 2026
+5 −0
Merged

invalidate UI render instance cache when freeing model instances #7514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions code/model/modelread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include "math/fvi.h"
#include "math/vecmat.h"
#include "model/model.h"
#include "model/modelrender.h"
#include "model/modelreplace.h"
#include "model/modelsinc.h"
#include "parse/parselo.h"
Expand Down Expand Up @@ -338,6 +339,10 @@ void model_instance_free_all()
{
size_t i;

// invalidate the UI render instance cache first so it doesn't retain stale references
// into Polygon_model_instances after the loop below
model_clear_cached_ui_render_instances();

// free any outstanding model instances
for ( i = 0; i < Polygon_model_instances.size(); ++i ) {
if ( Polygon_model_instances[i] ) {
Expand Down
Loading