Skip to content

[NF] Script to split affine transform into components - #1347

Open
AlexVCaron wants to merge 11 commits into
scilus:masterfrom
AlexVCaron:feat/scil-transform-split
Open

AlexVCaron wants to merge 11 commits into
scilus:masterfrom
AlexVCaron:feat/scil-transform-split

Conversation

@AlexVCaron

Copy link
Copy Markdown
Collaborator

Quick description

Split a affine transformation into components (translation, rotation, scale, shear). Only a subset of outputs is currently implemented, based on needs, that is :

  • Rotation : the 4x4 matrix, XYZ Euler angles, or axis+angle (aka Rodrigues)
  • Translation : the 3x1 vector
  • Scale : 4x4 matrix
  • Shear : 4x4 matrix

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copilot AI and others added 10 commits August 11, 2026 19:33
Co-authored-by: AlexVCaron <9435962+AlexVCaron@users.noreply.github.com>
Co-authored-by: AlexVCaron <9435962+AlexVCaron@users.noreply.github.com>
Co-authored-by: AlexVCaron <9435962+AlexVCaron@users.noreply.github.com>
Co-authored-by: AlexVCaron <9435962+AlexVCaron@users.noreply.github.com>
Co-authored-by: AlexVCaron <9435962+AlexVCaron@users.noreply.github.com>
Co-authored-by: AlexVCaron <9435962+AlexVCaron@users.noreply.github.com>
Co-authored-by: AlexVCaron <9435962+AlexVCaron@users.noreply.github.com>
Co-authored-by: AlexVCaron <9435962+AlexVCaron@users.noreply.github.com>
Co-authored-by: AlexVCaron <9435962+AlexVCaron@users.noreply.github.com>
Co-authored-by: AlexVCaron <9435962+AlexVCaron@users.noreply.github.com>
@AlexVCaron AlexVCaron changed the title Feat/scil transform split [FEAT] Script to split affine transform into components Sep 3, 2026
@AlexVCaron AlexVCaron changed the title [FEAT] Script to split affine transform into components [NF] Script to split affine transform into components Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.17391% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.62%. Comparing base (aa4b761) to head (de4b92c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1347      +/-   ##
==========================================
+ Coverage   72.60%   72.62%   +0.01%     
==========================================
  Files         301      302       +1     
  Lines       26286    26450     +164     
  Branches     3700     3735      +35     
==========================================
+ Hits        19086    19208     +122     
- Misses       5650     5671      +21     
- Partials     1550     1571      +21     
Flag Coverage Δ
smoketests 69.78% <74.45%> (+<0.01%) ⬆️
unittests 14.27% <20.10%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Scripts 75.38% <90.32%> (+0.03%) ⬆️
Library 69.32% <70.49%> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arnaudbore
arnaudbore requested a review from frheault September 16, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants