Further refinement of poster plots - #21
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refines poster figure aesthetics by tightening the pipeline→priors connector geometry and polishing hero-plot legend presentation for clearer poster readability.
Changes:
- Reduced default funnel/connector band height in
pipeline_priors.py. - Updated hero plot series legend labels and adjusted legend anchoring in
hero.py.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| poster/pipeline_priors.py | Tweaks default funnel height used in the pipeline+priors composite poster banner. |
| poster/hero.py | Refines legend labels/casing and nudges legend placement for the hero plot. |
Suppressed comments (1)
poster/pipeline_priors.py:212
- The
--funnel-heightCLI default is another hard-coded literal. To prevent drift frommake_figure's default, consider referencing a shared module-level default (e.g.DEFAULT_FUNNEL_H) instead of repeating the numeric literal here.
ap.add_argument("--funnel-height", type=float, default=1.30, help="height of the connector band, inches")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
120
to
123
| pipe_frac=0.76, | ||
| pipe_scale=1.45, | ||
| funnel_h=1.75, | ||
| funnel_h=1.30, | ||
| label=DEFAULT_LABEL, |
| ("barabasi_albert_age_constrained", "Barabási–Albert (age-constrained)", "#2a78d6"), | ||
| ("barabasi_albert_random_topo", "Barabási–Albert (random topo)", "#008300"), | ||
| ("stochastic_block_model", "Stochastic block model", "#d55181"), | ||
| ("barabasi_albert_age_constrained", "Barabási–Albert (Hier. Topology)", "#2a78d6"), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.