Repository navigation
CI: run the comma-locale tests on Linux - #322
Merged
Merged
Conversation
Ubuntu runners have none, so the locale-independence tests from #310 skipped themselves there; only Windows and macOS ran them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The locale-independence tests added in #310 switch
LC_NUMERICto a comma-decimal locale and skip themselves when none is installed. Ubuntu runners have none, so on Linux they printed "No comma-decimal locale installed" and skipped; only Windows and macOS ran them. This generatesde_DE.UTF-8before the unit tests on the native Ubuntu jobs.